Page 1 of 2

1.6.9 patches list and bugs report

Posted: Wed Apr 26, 2017 7:55 pm
by axew3
At date of each patch on 1.6.9, this topic will be updated.

views/page-forum.php
has been updated to correctly push urls if on multipage/posts.
class.wp.w3all-phpbb.php has been patched to correctly delete users and deactivate in phpBB at mean time. It was lost since latest update and the php was return error.

You can download singles files to be replaced directly from here:
https://plugins.trac.wordpress.org/brow ... tion/trunk

Or download the plugin and replace if more comfortable.

Please report if any bug.

Re: 1.6.9 patches list and bugs report

Posted: Wed Apr 26, 2017 11:00 pm
by axew3
x multisite WP MUMS:
class.wp.w3all-phpbb.php and wp_w3all.php files has been patched to fix MUMS bug:
addition fail when site is created by admin. The created/related wp user isn’t created into phpBB also.

download here files
https://plugins.trac.wordpress.org/expo ... -phpbb.php

or re-download plugin and overwrite.

Re: 1.6.9 patches list and bugs report

Posted: Thu Apr 27, 2017 8:57 am
by axew3
Old style md5 password in phpBB issue:
PHP Fatal error: Uncaught exception 'Exception' with message 'Unsupported hash format.' in ...addons/bcrypt/bcrypt.php:111
Fix to recognize old md5 style password of phpBB applied.
Now also old styles passwords are correctly passed for check into WP and no more errors about.
Substitute the file wp_w3all.php with the new one:
https://plugins.trac.wordpress.org/expo ... _w3all.php
wp_w3all 1.6.9 has been just patched to resolve definitively this issue.

Re: 1.6.9 patches list and bugs report

Posted: Fri Apr 28, 2017 2:51 pm
by axew3
a question many times thrown in the air, was:
what about if an user have two tabs opened on browser one of wp home and other with page forum, AND the user logout on tab where WP home, AND so open the other tab and start to navigate the iframe? Will result as logged out into phpBB, but the WP page until not reloaded will display that the user is apparently logged in, on WP admin bar.

The work around added is very simple, but remember that since these are javascript tricks, they point to work to default WP themes ID and CLASSES html elements.
I will try to post an help to understand this if somebody interested: any phpBB event can be passed in this way to wp with ajax. This can be applied with the code about ajax PM count, not in the default overall_footer.html js code (because into default js code to be added into phpBB overall_footer.html the window.onload = function() not exist! ...)

The simple workaround:
On phpBB overall_footer.html js added code, window.onload = function() , has become this:

Code: Select all

window.onload = function() {
var pmn = "{PRIVATE_MESSAGE_COUNT}";
var w3all_phpbb_u_logged = "{S_USER_LOGGED_IN}";
// to send to wp at once here, like this: #w3all_phpbbpmcount=val#w3all_phpbbnotifycount=val#etc etc etc
var w3appendevents = '#w3all_phpbbpmcount=' + pmn + '#w3all_phpbb_u_logged=' + w3all_phpbb_u_logged;
parent.w3all_ajaxup_from_phpbb(w3appendevents);
}
while on page forum, this code function (that receive and execute)

Code: Select all

		function w3all_ajaxup_from_phpbb(res){
			var w3all_phpbbpmcount = /.*(#w3all_phpbbpmcount)=([0-9]+).*/ig.exec(res);
      if(w3all_phpbbpmcount !== null){
         w3all_ajaxup_from_phpbb_do(w3all_phpbbpmcount[2]);
       }
     }
has been rewrite into this (still not added in the advanced 1.6.9 tutorial how to and related code to copy):

Code: Select all

	function w3all_ajaxup_from_phpbb(res){
			var w3all_phpbb_u_logged  = /#w3all_phpbb_u_logged=1/ig.exec(res);
			 if( res.indexOf('#w3all_phpbb_u_logged=') > -1 && w3all_phpbb_u_logged == null && null !== (document.getElementById('wp-admin-bar-my-account')) ){
        window.location.reload(true);
       }
			var w3all_phpbbpmcount = /.*(#w3all_phpbbpmcount)=([0-9]+).*/ig.exec(res);
      if(w3all_phpbbpmcount !== null){
         w3all_ajaxup_from_phpbb_do(w3all_phpbbpmcount[2]);
       }
   } // END function w3all_ajaxup_from_phpbb(res){
the concept is clear, maybe it will changed little more before to be published also online.

This is effectively working already by the way, into this online example.

Re: 1.6.9 patches list and bugs report

Posted: Sat Apr 29, 2017 9:26 am
by axew3
i suspect from reports, that something goes wrong in some case when option Deactivate user until WP confirmation is set to yes on wp_w3all config.
if any problem in the while, and you have activate this option, disable it.

Re: 1.6.9 patches list and bugs report

Posted: Sat Apr 29, 2017 2:15 pm
by axew3
wp_w3all.php has been patched for WP MU multisite to NOT allow admins to add a new user in WP, if already exist into phpBB