Page 1 of 2
Pre release tests (1.6.7 R.C)
Posted: Fri Mar 31, 2017 12:33 pm
by axew3
To test code before release:
https://plugins.trac.wordpress.org/brow ... tion/trunk
Code: Select all
= 1.6.7 =
*Release Date - ?? Apr, 2017*
* Add profile language update between phpBB and WordPress for users
* Fix deactivated phpBB user re-added in WordPress (maybe deactivated in phpBB due to deletion of the user in WordPress). Now a deactivated phpBB user will not be added or re-added into WordPress, as default behavior
* Fix display correct number of topics for each different widget instance setup
* Add avatar row on wp login widget user's info
* Fix Last Topics Widget html output to be more like any WP widget default output: fix correct separation between code and text output on same file (views/phpbb_last_topics.php)
* Improve query execution time for Last Topics Widget when Avatar active: the query is executed by searching for 'phpBB email hash' which is Key Index into phpBB db, and not by username.
* Fix uninitialized variables bug in WP_w3all admin config page, that was leading WP_w3all admin config page to emit notice errors as html output into Config fields about avatars or Preferences (where php ini were set to display php errors/notices: it was breaking options fields).
Unfortunately, i can't find out where the pre-release should be downloaded as unique zip, so any file need to be downloaded.
Re: Pre release tests (1.6.7 R.C)
Posted: Fri Mar 31, 2017 12:58 pm
by axew3
To test code before release:
https://plugins.trac.wordpress.org/brow ... tion/trunk
On the above going on test code, many files have been patched and changed due to all above fixes.
views/
phpbb_last_topics.php have change code, wrapping
<table> elements inside default WordPress elements
<ul> <li>, for both avatar or not avatar output. Little css style cleanup as suggested by @kaspir for table code (to review)
The code has been prepared for the addition about 'css classes' to elements (option that will be added into wp_w3all config page), so on plugin update will be not necessary re-apply css styles on widget, if it were customized.
files
views/
login_form_include_iframe_mode_links.php
and
views/
login_form_include_noiframe_mode_links.php
have been also updated to add avatar and to fix html output as above (separating the html code from text for example)
the code that display avatar on code
Code: Select all
echo '<li class="">' . get_avatar(get_current_user_id(), $w3all_last_t_avatar_dim) . '</li>';
has been set by default as is the dimension that is setup for avatars on last topics widget.
Maybe this need to be a separated option on config?
.....
Re: Pre release tests (1.6.7 R.C)
Posted: Fri Mar 31, 2017 9:13 pm
by Goofkop
So i am back from Finland and see a new update.
I updated the plugin but in the login widget i didn't see my forum avatar.
http://imgur.com/a/CkKpK
And i have the option: Use phpBB avatar to replace WordPress user's avatar on Yes.
Before the update i saw my forum avatar on my replies and other posts. But now it is the unknown avatar i can choose on my WP options.
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 10:27 am
by kaspir
Doing this now:
-Saving/backing up my current plugin files
-Updating to new version
-Re-Applying my custom edits
Will be back to inform, maybe get you something about that avatar @Goofkop
EDIT: Goofkop is correct, on plugin update, before doing any changes, the avatar is only pulling the gravatar links only.
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 10:50 am
by axew3
checking, because the code search for email hashes now, and so something is wrong ... arghhh
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 10:58 am
by kaspir
axew3 wrote: ↑Sat Apr 01, 2017 10:50 am
checking, because the code search for email hashes now, and so something is wrong ... arghhh
YO, the problem is in this file: class.wp.w3all-phpbb.php
I replaced just this one file with the same file from version 1.6.6 and all avatars popped up! Everyone use this as a temporary fix until the boss submits patch fix.
EDIT: I think using the 1.6.6 file here made my 'unread post' marker not work now.
But it's a suitable resolution for me for now.