Coming 2.8.8 logs

[axew3]

Template integration improvements (the overall_footer.html js code has been fixed)
phpbb-wordpress-template-integration-iframe-v5

see all logs about here (thanks to https://surferparadise.de/ for each input on revert/reverse all the required, so to have finally a decent starting code that will fit any template):
2.8.8 template integration improvements and 2.8.8 pre-logs

Note that files:
/wp-content/plugins/wp-w3all-phpbb-integration/views/wp_w3all_phpbb_iframe_short.php
/wp-content/plugins/wp-w3all-phpbb-integration/addons/page-forum.php
and the overall_footer.html js code have been definitively updated to fit a decent result into any theme without having to adjust it.

[axew3]

Plugin deactivation bug
I discovered that in case of deactivation of the plugin, and due to a specific change done along the 2.8.., when the plugin is set as deactivated,
changing on the wp_w3all.php file, the line of code

Code: Select all

// FORCE Deactivation WP_w3all plugin //
//$w3deactivate_wp_w3all_plugin = 'true';

into

Code: Select all

// FORCE Deactivation WP_w3all plugin //
$w3deactivate_wp_w3all_plugin = 'true';

but the connection values to the phpBB db have been set, it is practically impossible to access to the wp-admin if not renaming the plugin folder into something else, so to disable it. But at this time, will so not be possible to change the db connection values to the linked phpBB (or, but it is harder, and may only for advanced users, going to the mysql related option and changing values directly into the related record so bypassing any problem).

Let say we migrate the entire site to a localhost (as i did right now) and it is necessary to change the db connection values to fit the new environment.
On 2.8.8 deactivating the plugin using

Code: Select all

// FORCE Deactivation WP_w3all plugin //
$w3deactivate_wp_w3all_plugin = 'true';

will effectively disable the db connection settings to the linked phpBB, leaving the possibility to access to the wp-admin and change values of the connection. In this state, after settings have been changed to fit the new phpBB connection, the plugin will still return that connection values are wrong (RED button).
Then resetting to

Code: Select all

// FORCE Deactivation WP_w3all plugin //
//$w3deactivate_wp_w3all_plugin = 'true';

all will work fine with the new settings, assuming that the phpBB cookie domain (and all about settings updates required when a site migrate to another server) has been updated also, to fit the new environment.

[axew3]

phpbb_last_topics_withimage_output_shortcode bug

So, i just looked into the file
/wp-content/plugins/wp-w3all-phpbb-integration/views/phpbb_last_topics_withimage_output_shortcode.php
i understood the reason of your question about image dimension because as it was, images are very big, and going outside the screen?
I just fixed it as you can see here, with a more decent result:
https://www.axew3.com/w3/phpbb-grid-lis ... tachments/

See the result of 2.8.8 fly fixes in this example: https://www.axew3.com/w3/phpbb-grid-lis ... tachments/

To fix it like this, i just changed this line

Code: Select all

echo '<a style="border:0;margin:0;text-decoration:none;color:transparent" href="'.$w3all_url_to_cms.'/download/file.php?id='.$w3topic->attach_id.'&TB_iframe=true" class="thickbox"><img alt="'.$w3topic->topic_title.'" src="'.$w3all_url_to_cms.'/download/file.php?id='.$w3topic->attach_id.'" /></a>

into this:

Code: Select all

echo '<a style="border:0;margin:0;text-decoration:none;color:transparent" href="'.$w3all_url_to_cms.'/download/file.php?id='.$w3topic->attach_id.'&TB_iframe=true" class="thickbox"><img style="width:100%" alt="'.$w3topic->topic_title.'" src="'.$w3all_url_to_cms.'/download/file.php?id='.$w3topic->attach_id.'" /></a>

so substantially adding style="width:100%" to the img tag.

Without this, i see that images are too big. The result is the above now into gutenberg or common themes.

Bug:
I also see that the addition of the shortcode on posts or pages, when we try to add it and the phpBB posts to be retrieved are not found into the specified phpBB cat, the page/post update on WP fall into a JSON error (and even if the shortcode is added and the page created, the error come out). It has been fixed, and 2.8.8 is coming probably within tomorrow fixed about this.

2.8.8 add param info_right_or_bottom
viewtopic.php?t=783
It also fix the image that is automatically center positioned when open on popup.

It is a big mess this file
/wp-content/plugins/wp-w3all-phpbb-integration/views/phpbb_last_topics_withimage_output_shortcode.php
that works very well, but i understand that to be customized maybe is not so easy, especially because full of unwanted things on it.
It will be soon cleaned and improved.

[axew3]

2.8.8 has been released!

[Ezrael]

Runs super smoothly ! Amazing Plugin

[axew3]

Ah yes! Until the next bug isn't discovered!