2.5.1 released, and coming 2.5.2 logs

User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

2.5.1 released, and coming 2.5.2 logs

Post by axew3 »

= 2.5.1 =
*Release Date - 21 Jan, 2022*

* Fix: function verify_phpbb_credentials() to correctly setup main connection config vars, so to correctly execute all subsequent main tasks into widgets etc
* Fix: check valid emails formats for frontend plugins, before being updated into WordPress
it should work fine under any aspect now, please report if any issue detected.

Please note that just after 2.5.1 release the file
class.wp.w3all-phpbb.php
was issuing a Php notice, when in debug mode, and phpBB database connection config values still not set, into the plugin config admin page.

https://plugins.trac.wordpress.org/expo ... -phpbb.php

but this was just a really secondary issue, happening in the above mentioned circumstance and leading to no problems nor errors at all.

On coming 2.5.2 lang files should be fixed.
Please report if you found any bug into 2.5.1 or there is some suggestion on air :)
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: 2.5.1 released, and coming 2.5.2 logs

Post by axew3 »

Language file has been fixed/updated on 2.5.2.
The new wp-w3all-phpbb-integration.pot will be available on next plugin release
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: 2.5.1 released, and coming 2.5.2 logs

Post by axew3 »

p.ss
about iframe that loads but page still display the preloader...
the unique speedup i can see at moment is to apply this into the wp page forum:

Code: Select all

jQuery('#w3idwloader').css(\"display\",\"none\");
exactly just after this line:

Code: Select all

function w3all_ajaxup_from_phpbb(res){
because when this function fire, it is sure that the phpBB loaded and data about iframe resize have been sent.
So until V6 code, we can assume that's the right time to remove the preloader from page.
Isn't it? It has been applied here into this example already.
User avatar
floxshifu
User www
User www
Posts: 57
Joined: Sun Sep 18, 2016 6:14 pm

Re: 2.5.1 released, and coming 2.5.2 logs

Post by floxshifu »

axew3 wrote: Sat Jan 22, 2022 11:16 pm Language file has been fixed/updated on 2.5.2.
The new wp-w3all-phpbb-integration.pot will be available on next plugin release
Yeaaaah ! It rocks !
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: 2.5.1 released, and coming 2.5.2 logs

Post by axew3 »

Ehi! I felt like a stupid yesterday night about this.
I was on poedit and creating the new .pot.
All was working fine creating it then after, with the .pot, the related translation test for example creating
wp-w3all-phpbb-integration-it_IT.po
then i switched an user to ita lang to see results.
Nothing. Hours to understand that (i think this is the reason why):
if a translation lang file EXIST into a plugin /language folder, then it is automatically added into
/wp/wp-content/languages/plugins
when you install a language.
But if i go to activate ITA lang for example, and
related lang files wp-w3all-phpbb-integration-it_IT.po wp-w3all-phpbb-integration-it_IT.mo do not exists into the plugin languages folder
then you have to manually add those files into
/wp/wp-content/languages/plugins

i loosed my mind on this :D

p.s i do not know if you deactivate a plugin and reactivating it may transfer files into language folder once added, or would be necessary to uninstall a plugin and reinstall it. I assume the second. But i will try sometime-
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: 2.5.1 released, and coming 2.5.2 logs

Post by axew3 »

About attachment problem into post shortcode when different images/files have been added with same name:
https://www.phpbb.com/community/viewtop ... &t=2612511
i think i have understand how the problem can be fixed using attachments placeholders ids and attachment time.
The algo about is little hard?

Let say we have on post text:

Code: Select all

[attachment=1]image.png[/attachment]
[attachment=2]image.png[/attachment]
[attachment=5]image.png[/attachment]
[attachment=3]image.png[/attachment]
using attachments array and checking against ids order, it is necessary to know which belong to what, based on the fact that

Code: Select all

[attachment=1]image.png[/attachment]
is the last added, num 2 the one added before 1, the num 5 is the older.

So it is necessary this little algorithm to fix the thing. I think it is the unique possible way and the one used by phpBB?
Locked