Page 2 of 2
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 1:02 pm
by Goofkop
I just waiting for new update!
Thanks for al the work axew3 and kaspir!
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 3:09 pm
by axew3
hello on board again ... lunch time, some water to a garden (spring time!) ...
well, i had to test out with a custom avatar for an user that had an avatar in phpBB, to see that really all working fine, and not only apparently.
https://plugins.trac.wordpress.org/brow ... tion/trunk
on class.wp.w3all-phpbb.php (that has patched already on
trunk about this)
Code: Select all
$uavatars = $w3db_conn->get_results( $w3db_conn->prepare("SELECT username, user_avatar, user_avatar_type FROM ".$config["table_prefix"]."users WHERE user_email_hash IN(%d) ORDER BY user_id DESC", $w3unames ));
has been replaced by
Code: Select all
$uavatars = $w3db_conn->get_results( "SELECT username, user_avatar, user_avatar_type FROM ".$config["table_prefix"]."users WHERE user_email_hash IN(".$w3unames.") ORDER BY user_id DESC" );
on the updated file:
Code: Select all
// this not work by email_hash, but were necessary by username
// $uavatars = $w3db_conn->get_results( $w3db_conn->prepare("SELECT username, user_avatar, user_avatar_type FROM ".$config["table_prefix"]."users WHERE user_email_hash IN(%d) ORDER BY user_id DESC", $w3unames ));
$uavatars = $w3db_conn->get_results( "SELECT username, user_avatar, user_avatar_type FROM ".$config["table_prefix"]."users WHERE user_email_hash IN(".$w3unames.") ORDER BY user_id DESC" );
i had to rename also vars, it is little confusing maybe, username or what remind to it into avatars functions are sometime email_hashes instead. But all now should work as expected.
All the code about avatars, is wrapped on bottom of file
class.wp.w3all-phpbb.php
inside comments
//#######################
// START ABOUT AVATARS
//#######################
... .... ...
//#######################
// END ABOUT AVATARS
//#######################
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 4:03 pm
by axew3
ops, i had leave test exit code into file, so if downloaded before this post i'm sorry, the file class.wp.w3all-phpbb.php has been just updated, and now, all should work fine about avatars!
Re: Pre release tests (1.6.7 R.C)
Posted: Sat Apr 01, 2017 4:37 pm
by axew3
also the overall footer code has been patched (this to add on phpBB overall_footer.html template file), so to apply it is necessary to replace the old and recompile stale template into phpBB.
The code has been added just to not scroll top iframe when on reply we click on smile. ... let test
... ok work ...!
https://www.axew3.com/w3/2016/02/embed- ... esponsive/
Code: Select all
<script type="text/javascript">
// TO ACTIVATE phpBB lightbox events remove /* and */ here below
/*
$(document).on('mouseup', '.postimage', function(){
//var w3allappend = "getw3all_lightbox";
if ('parentIFrame' in window) window.parentIFrame.scrollToOffset(0,0);
//if ('parentIFrame' in window) window.parentIFrame.sendMessage(w3allappend);
});
*/
$(document).on("click", "a", function() {
var href = $(this).attr("href");
var w3allappend = href;
var w3all_parent_element_id = $(this).parent().get( 0 ).id; // detect and avoid/allow certain behaviors
var w3all_onclick_smile = (w3all_parent_element_id.indexOf('smiley-box') > -1);
var w3all_onview_topic = (href.indexOf('viewtopic.php') > -1);
var w3all_onview_attach = (href.indexOf('file.php') > -1);
var w3all_onview_post = /#p[0-9]+/ig.exec(href);
var w3all_ck_quickmod = (href.indexOf('quickmod') > -1);
if ( w3all_ck_quickmod == true || w3all_onview_topic == false && w3all_onview_attach == false && w3all_onview_post == null && w3all_onclick_smile != true ) {
if ('parentIFrame' in window) window.parentIFrame.scrollToOffset(0,0);
}
if ('parentIFrame' in window) window.parentIFrame.sendMessage(w3allappend);
});
$(document).on('click', '.quick-login', function(){
var w3allappend = "phpbb_quick_login";
if ('parentIFrame' in window) window.parentIFrame.scrollToOffset(0,0);
if ('parentIFrame' in window) window.parentIFrame.sendMessage(w3allappend);
});
$('form').on('submit', function() {
var href = $(this).attr("action");
var ckr = (href.indexOf('#preview') > -1);
if(ckr == true){
var w3allappend = href;
if ('parentIFrame' in window) window.parentIFrame.scrollToOffset(0,0);
if ('parentIFrame' in window) window.parentIFrame.sendMessage(w3allappend);
}
});
</script>
<script type="text/javascript" src="iframeResizer.contentWindow.min.js" defer></script>
<!-- EVENT overall_footer_body_after -->
asking to myself, if there is another way to achieve all the joke, and if really was a good idea to move the scroll code form page-forum.php to overall_footer.html of phpBB
Re: Pre release tests (1.6.7 R.C)
Posted: Sun Apr 02, 2017 9:44 am
by axew3
Reporting here the messy thing also:
It were a problem with trunk directory on repository (or i’ve not understand how it work!).
Version 1.6.7 was resulting as released, in the testing version since last day.
It was containing a problem about avatars now updated and several fixes that have been applied. The correct version to download is NOW available, so please replace all files if downloaded/updated prior this post.
It will never more happen, i’m sorry for inconvenience … but the trunk directory on repository should not contain the development version, that should not appear as released and downloadable?