Page 8 of 8
Re: url segments not propagating
Posted: Thu Nov 10, 2016 5:13 am
by mikotoiii
axew3 wrote:i've not understand (as +- ever maybe): have you resolved/fixed all?
I can understand why you'd be confused. This thread kind of split off, there was my original issue which I fixed and will be implemented in the master source, and then there's floxshifu's issue, which was semi solved by the fix i came up with but he's still having an issue with w3all not handling an external link being set to a forum topic.
Re: url segments not propagating
Posted: Thu Nov 10, 2016 8:46 am
by axew3
Thank you to be so gentle ...
Re: url segments not propagating
Posted: Thu Nov 10, 2016 10:09 am
by floxshifu
mikotoiii wrote:Gotcha, and no worries on the Feench thing, I know enough to get by while browsing your site.
I didn't understand that it was being set as a forum link type in the acp. Check out this article it might have the solution for you:
http://area51.phpbb.com/phpBB/viewtopic ... 71&t=31522
Hello,
Many thanks, I'll try and I'll give you a return
EDIT :
There is no more this line of code in phpBB 3.1.x I can't find where I can edit the type for forumlink... I'm sorry, if you can help me ..
EDIT 2 :
I have found the code fix for Prosilver. You gave me the Subsilver code fix
So, my problem is now fixed! Thank you so much for the help, I appreciate a lot, and your patience.
Here is the link with the modification to do on Subsilver and Prosilver :
https://www.phpbb.com/support/docs/en/3 ... w-windows/
Re: url segments not propagating
Posted: Thu Nov 10, 2016 1:31 pm
by mikotoiii
No problem, glad you got it working.
One thing to note with this is that you'll almost certainly get an error in your console indicating that the origin and remote are not on the same domain
There doesn't seem to be any way around this, and from what I could see, there is no easy identifier that any forum topic is actually a link (phpbb treats it as a regular topic number, then executes the link once it's clicked), so there's no real way to integrate a permanent fix for this into the plugin, that I can see. We can always steer people towards the phpbb link you provided which outlines how to do it in many styles.
Thanks.
Re: url segments not propagating
Posted: Thu Nov 10, 2016 5:55 pm
by floxshifu
mikotoiii wrote:No problem, glad you got it working.
One thing to note with this is that you'll almost certainly get an error in your console indicating that the origin and remote are not on the same domain
There doesn't seem to be any way around this, and from what I could see, there is no easy identifier that any forum topic is actually a link (phpbb treats it as a regular topic number, then executes the link once it's clicked), so there's no real way to integrate a permanent fix for this into the plugin, that I can see. We can always steer people towards the phpbb link you provided which outlines how to do it in many styles.
Thanks.
Yep, I've seen it.
Maybe add a little note in the plugin readme.txt to specify the modification to do with forum-link in phpBB 3.1.x, I think it maybe help some people in the next time
Thank you both for your help