2.8.8 template integration improvements and 2.8.8 pre-logs

[axew3]

What it is about? For what you use this extension?
It throw an error that should be really easy to fix.

[Ezrael]

Normally phpbb post all images Among themselves which waste space and doesn't look really nice.

The Inline images in attachments extension together with the Lightbox inline images which you can see in this topic

[axew3]

It throw error but all look fine. To fix it btw would be just to edit the related file where the error come out, outputted by the extension. It seem a load event inside a ready? It seem to me that it could be removed $(document).ready(function() { but maybe i am wrong, i will not obviuosly investigate more about

Code: Select all

<script type="text/javascript">
$(document).ready(function() {
/* Add resize attach in phpBB3.1 && Anvar bb3.mobi */
	$('dl.thumbnail img, dt.attach-image img').load(function() {
		var w  = $(this).width();
		var h = $(this).height();
		var rh = $(this).height();
		if (w > h) {
			h = w;
			w = w*(h/rh);
		}
		$(this).width(w*(2/3));
		$(this).height(h*(2/3));
	});
	$('dl.thumbnail img, dt.attach-image img').each(function() {
		var src = $(this).attr('src');
		$(this).attr('src', '');
		$(this).attr('src', src);
	});
});
</script>

while the definitive default code that return the correct and decent result into both the shortcode and page-forum.php template integration could be at moment this:

Code: Select all

   if( typeof t != 'undefined' || t != false )
   {
     t.setAttribute("style", "position:fixed;top:0;left:0;width:100%;padding:0");
   }

The added padding:0 cause the vertical forum padding to be zero on top/bottom. No space between the iframe and the WP page.
Removing it, the padding on top will be ok while the bottom differ of some pixel (almost into my prosilver theme tests).

[Ezrael]

Btw:

Looks like there is an issue on your page. The page looks not normal on my phone.

[ale]

I see!
I just still did not applied here the same, I will do this morning when in 2/3 hours I will be at home see you later!

[axew3]

Applied also here. All right as you can see now:

Code: Select all

t.setAttribute("style", "position:fixed;top:0;left:0;width:100%;padding:0");

or

Code: Select all

t.setAttribute("style", "position:fixed;top:0;left:0;width:100%;");

render a decent result on both gutenberg themes using shortcode and default themes using page-forum.php.

It result that, with the new resizer code, it is still required the old fix (accepted as solution even by David, the lead developer of the resizer lib) and it is as it was for the old.

The difference here is:
if you apply padding:0 as it is right now into this example, you see there is no gap space in phpBB header and footer between the border of the phpBB (.wrap) and the page body of phpBB, and it let to center vertically the iframe (top and bottom).
If you remove padding:0 the gap space on top is regular, while the one on bottom output result with less space. This was not happening on old resizer, after the fix applied. On v5 it seem to be ignored, the little vertical gap is not "solved".
Into some theme it is maybe not so important, while the exact vertical position is maybe important into some other theme.
I will try to find out another fix if possible, even if this already give us practically any solution, that anyway in some case will be required to be adjusted to fit particular requirements. Let just try to figure out what other trick could be used!

[EDITED]