Testing 2.4.5 new coming release

[axew3]

Hello cool guys and really sorry for the delay! I'm alive, still free, and full of hopes

I'm over to check all forum's questions, searching for patches to apply where required.
Started yesterday dedicating some time, and tested by the way the 2.4.4 code working fine into wp 58 without any problem (until now).

Please, remember me in reply if you like, anything you note that require to be may adjusted (and i probably will forget since options and configurations lead to numerous integrations scenarios). I will look into topics these days.

Any hint here will be really appreciated!

One i've found really strange:
i setup the option "add user in phpBB as deactivated when register in wordpress"
result: user active in phpBB.
REASON:
when WordPress create a new user, immediately after, the profile_update hook fire.
The reason why this happen is not clear to me, since it was intended that this hook should fire only when an user update his profile,
and not when it is created, or is it (mine) a wrong consideration?

An rc release will provided very asap in these days or 2.4.5 will be directly released if i will have the time to test it out about everything (or the most).

p.s I also appreciated any of yours support, that i felt along my bad time, in any way it had happen.
Really appreciated. And so helpful.
Thank you!

[axew3]

One i've found really strange:
i setup the option "add user in phpBB as deactivated when register in wordpress"
result: user active in phpBB.
REASON:
when WordPress create a new user, immediately after, the profile_update hook fire.

The problem has been resolved, this way at moment:

Code: Select all

 public static function phpbb_update_profile($user_id, $old_user_data) {

// the profile_update hook seem to fire (also and may should not) just after an user is created.
// so return here if the $_GET['action'] == 'register' detected
// anyway, may some other external plugin will work with his own vars: so may add here 

 if ($user_id == 1 OR $_GET['action'] == 'register'){ return; }

The reason of the little code addition is clear. Return before subsequent code go to update the just created user into phpBB and activating him.
To get this compatible with any scenario/plugin and not the default wp, seem that will require a trick more.
I have an idea, but any suggestion would be welcome.

After this anyway there was another problem (reported and detected time ago, and never solved):
If i deactivate an user in wp, then it is deactivated also in phpBB.
But in wordpress, a deactivated user can reset his password, and when the reset happen, again, the code was going to update the user in phpBB with the new pass and activating.
This has been definitively fixed in short, patching the

Code: Select all

public static function phpbb_pass_update($user, $new_pass) {

and just checking on it if the user have (or not) roles in wp: if not, the user will not be reactivated in phpBB.

The same should be fixed for multisite part of the the code? going to check asap, i do not remember if this bug was affecting also the wp multisite.

[axew3]

Fixed public static function w3_phpbb_ban()
to avoid that users with excluded id or email, results as banned, when domain email match
minor fixes

Fixed admin update email when on multisite an admin go to change user's emails.

Added transfer single user from phpBB to wp into related admin transfer screen

Fixed Wp to phpBB users transfer process hint, that was warning: 'if duplicated user found, you'll have to repeat the process from begin...'
Not true. The code about this were fixed time ago, so the hint is wrong.

Several little fixes all over.

[axew3]

The Buddypress profile fields integration has been removed.
The phpBB mChat extension integration has been removed.
All the code about these two has been cleaned up.

The phpBB wordpress extension will come embedded into plugin, and allow to register users into wordpress at same time, when they register in phpBB. As well it will allow to update email, password and url fields (both upc and acp).
It allow also redirects to wordpress, when autologin happen after registration, or (if option active) ever, at each phpBB login.
So that you may can redirect users to a welcome wp page (of course with user already logged in).
It icontain really all what is needed.
Very easy to add custom profile fields as more like: a little trick on 1.0.2 (this coming will be 1.0.1), will allow to do this with easy for anyone.
But will be on next.
The extension can also be used as standalone in phpBB, without installing the wordpress phpBB integration plugin, to update email, password and url fields
viewtopic.php?f=2&t=1667