1.8.1 phpBB WordPress released

[axew3]

Due to several additions and improvements, released the new 1.8.1 WP_w3all phpBB WordPress:

Code: Select all

= 1.8.1 =
*Release Date - 2 Feb, 2018*

* Fix: install admin on phpBB UID 2 and WP admin UID 1 have different usernames, so if there are posts into Last Topics Widgets or Last Topics Shortcode about this user, the avatar fail to display. 
* Fix an old - Admin related - avatar issue (secondary bug, but obscure the reason of this behavior): when an admin open the Discussion settings on WordPress administration: WP admin -> Settings -> Discussion, the avatars lists, show the viewing user avatar for all options, instead than different gravatars
* Add option: Retrieve phpBB avatars by using native phpBB file.php, that avoid to edit the .htaccess file on phpBB to get avatars available in WordPress, as suggested by Alexvrs. Check it here: https://www.axew3.com/w3/forums/viewtopic.php?f=2&t=622&p=2558#p2557
* Add feature: force user addition at same time into Wordpress when register and then login into phpBB (even if not in iframe mode). Check this: https://www.axew3.com/w3/forums/viewtopic.php?f=2&t=643
* Add feature: Mark Unread Messages into Last Topics using Font Awesome icons, as suggested by @kaspir. Check this: https://www.axew3.com/w3/forums/viewtopic.php?f=2&t=644#p2597
* Really improve the user transfer process WordPress users into phphBB. Check this https://www.axew3.com/w3/forums/viewtopic.php?f=2&t=642#p2592
* More minor fixes
* The online Help Install, has been little improved, while adding the new features hints/explanations. https://www.axew3.com/w3/cms-plugins-scripts/wordpress-plugins-scripts-docs/wordpress-phpbb-integration/

Download 1.8.1 plugin

[Alexvrs]

Hello!

Found out an error: if you use w3all without iframe, then in the top-level menu of the PM the wrong link is displayed (variable w3all_url_to_cms is not considered in the administrative part), this is related to the code in wp_w3all.php

Code: Select all

if ( defined( 'WP_ADMIN' ) ) {
......
} else { // not in admin
......
     $phpbb_on_template_iframe = get_option( 'w3all_iframe_phpbb_link_yn' );
     $wp_w3all_forum_folder_wp = get_option( 'w3all_forum_template_wppage' ); // remove from iframe mode links on last topics than
     $w3all_url_to_cms         = get_option( 'w3all_url_to_cms' );
......
}

for correct work I added the definition of variables and to the administrative section of the condition:

Code: Select all

if ( defined( 'WP_ADMIN' ) ) {
     $phpbb_on_template_iframe = get_option( 'w3all_iframe_phpbb_link_yn' );
     $wp_w3all_forum_folder_wp = get_option( 'w3all_forum_template_wppage' ); // remove from iframe mode links on last topics than
     $w3all_url_to_cms         = get_option( 'w3all_url_to_cms' );
......
} else { // not in admin
......
     $phpbb_on_template_iframe = get_option( 'w3all_iframe_phpbb_link_yn' );
     $wp_w3all_forum_folder_wp = get_option( 'w3all_forum_template_wppage' ); // remove from iframe mode links on last topics than
     $w3all_url_to_cms         = get_option( 'w3all_url_to_cms' );
......
}

Thanks for the great plugin!,
Please correct this small error.

[axew3]

going to commit your fix as soon ...
i will check before why i've do in this way, if there is a reason.
Instead to wrap into if defined( 'WP_ADMIN' ) two times, the solution if ok should be remove the condition? checking as soon.
Thank you Alexvrs and please do not forget in any case some time if possible, to take a look and give a shot like you're doing!

[axew3]

You're right but to fix this issue, the best way is to apply a little patch to the function

Code: Select all

function wp_w3all_toolbar_new_phpbbpm( $wp_admin_bar ) {

into wp_w3all.php file
where code:

Code: Select all

global $wp_w3all_forum_folder_wp,$w3all_url_to_cms,$w3all_phpbb_wptoolbar_pm_yn;

CHANGED INTO

global $w3all_phpbb_wptoolbar_pm_yn;

where code:

Code: Select all

$hrefmode = get_option( 'w3all_iframe_phpbb_link_yn' ) == 1 ? get_home_url() . "/index.php/".$wp_w3all_forum_folder_wp.'/?i=pm&folder=inbox">' : $w3all_url_to_cms.'/ucp.php?i=pm&folder=inbox';

CHANGED INTO:

Code: Select all

$hrefmode = get_option( 'w3all_iframe_phpbb_link_yn' ) == 1 ? get_home_url() . "/index.php/".get_option('w3all_forum_template_wppage').'/?i=pm&folder=inbox">' : get_option( 'w3all_url_to_cms' ).'/ucp.php?i=pm&folder=inbox';

because as correctly you've note, vars $wp_w3all_forum_folder_wp and $w3all_url_to_cms are not available: i should reverse when these values have been lost during some release update, but i can't figure out-

the commit has been done, 1.8.1 as been patched about this, the resulting fixed function to patch wp_w3all.php and fix this issue:

function wp_w3all_toolbar_new_phpbbpm( on wp_w3all.php file has been patched in this way:

Code: Select all

function wp_w3all_toolbar_new_phpbbpm( $wp_admin_bar ) {
		global $w3all_phpbb_wptoolbar_pm_yn;

	if ( defined("W3PHPBBUSESSION") && $w3all_phpbb_wptoolbar_pm_yn == 1 ) {
        $phpbb_user_session = unserialize(W3PHPBBUSESSION);
        if($phpbb_user_session[0]->user_unread_privmsg > 0){
        $hrefmode = get_option( 'w3all_iframe_phpbb_link_yn' ) == 1 ? get_home_url() . "/index.php/".get_option('w3all_forum_template_wppage').'/?i=pm&folder=inbox">' : get_option( 'w3all_url_to_cms' ).'/ucp.php?i=pm&folder=inbox';
        $args_meta = array( 'class' => 'w3all_phpbb_pmn' );
        $args = array(
                'id'    => 'w3all_phpbb_pm', 
                'title' => __( 'You have ', 'wp-w3all-phpbb-integration' ) . $phpbb_user_session[0]->user_unread_privmsg . __( ' unread forum PM', 'wp-w3all-phpbb-integration' ),
                'href'  => $hrefmode,
                'meta' => $args_meta );

       $wp_admin_bar->add_node( $args );
     }
  } else { return false; }
}

to directly download the patched wp_w3all.php 1.8.1 that fix this issue, link is here:
https://plugins.trac.wordpress.org/expo ... _w3all.php

TRUNK (all files) repository link:
https://plugins.trac.wordpress.org/brow ... tion/trunk

[AppJetty]

Thank , Got same error but fixed now..

[Alexvrs]

Hello axew3!

At the moment I'm using the phpBB version 3.0.14 forum, in this version there are no font-awesome fonts and everything connected with it, as a result I get a 404 error in the browser console, about not being able to download the download file ....../assets/css/font-awesome.min.css

The solution can be to add this font to the wp-w3all plugin itself, for example, this is done in the plugin Fruitful Shortcodes

Tnx!