HTML5, Using more CSS

User avatar
kaspir
Moderator
Moderator
Posts: 88
Joined: Mon Mar 20, 2017 2:38 pm
Location: USA
Contact:

HTML5, Using more CSS

Post by kaspir »

Any plans for preparing for HTML5 markup?
Image
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: HTML5, Using more CSS

Post by axew3 »

Yes! Of course but what do you mean to improve in this sense?
User avatar
kaspir
Moderator
Moderator
Posts: 88
Joined: Mon Mar 20, 2017 2:38 pm
Location: USA
Contact:

Re: HTML5, Using more CSS

Post by kaspir »

axew3 wrote: Tue Mar 21, 2017 9:33 pm Yes! Of course but what do you mean to improve in this sense?
In phpbb_last_topics.php, HTML5, doesn't support these anymore:

Code: Select all

cellpadding=\"0\" cellspacing=\"0\"
So I removed all from that file, and re-ran my html5 markup (if you even see my page, there a button in footer to test html5, try it).

At first glance, I thought the style= had to be moved to CSS also. Doesn't seem that way now though when I run checker, perhaps something I didn't know about table styles.

Also, the avatar images, and ANY image for that matter, needs to have the alt= tag for HTML5.
Image
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: HTML5, Using more CSS

Post by axew3 »

ok. It is necessary to change these attributes for elements in favor of css that can be added into same page forum.
Widgets code will be updated as soon to be more WP widgets structure like and to apply custom style with easy.

1.6.6 is coming today
User avatar
kaspir
Moderator
Moderator
Posts: 88
Joined: Mon Mar 20, 2017 2:38 pm
Location: USA
Contact:

Re: HTML5, Using more CSS

Post by kaspir »

Another reason I started this topic (not just html5 compliance) is that because, every update patch you release, the new files will over-write ours (assuming we have added class= for customizing CSS), therefor, everytime you release a new update, we will have to edit the plugin files each time to match our custom CSS. Why not the dev instead add widget-named classes, and the users (that's us!) only have to keep our CSS file, and hardly touch your plugin files.

I'm suggesting this because I feel that I understand html & css well enough to see the future work this plugin may create for me.

Lmk, maybe there's a reason I am missing, it's just the way I look at things.

EDIT: I wouldn't mind helping you with this... I mean I'm going to do it anyways!
Image
World of Phaos RPG online is making it's come back! Play free now!
Check out phpBB contributions & extension downloads. :P
User avatar
axew3
w3all User
w3all User
Posts: 2883
Joined: Fri Jan 22, 2016 5:15 pm
Location: Italy
Contact:

Re: HTML5, Using more CSS

Post by axew3 »

I wouldn't mind helping you with this... I mean I'm going to do it anyways!
This would be very nice! This is not maybe the right place to use this GPL code as example site ... axew3.com is too much personal domain name maybe? But this is just an example, hosted here. Development core files are hosted at wp.org repository.
Contributors can be added anytime.

About html code on last topics widget (or login widget mode files which files are on /views/ plugin's folder),
it was coded using table and td for avatars mode, because, despite all developers like strong use of ul li elements, i remain into my opinion (maybe wrong) that i have much more precise control over elements, using less css when i need a middle vertical align for example, but not only this ... anyway, code widget will be changed to be completely like any other WP default widget.

Let know about, i will follow adding code and adding a new menu into wp_w3all config, related to styles to apply on widget's elements.
So when plugin update, the custom css applied will not be lost. The widget code will be rewrite to be exactly done with same elements for avatar or not avatar mode, using ul li and all others default WP elements. Style element or id, or class, will become variables (which will be possible to setup into wp_w3all config page). It will be added into next coming 1.6.7, 1.6.8 at max.
Post Reply