pre - 2.8.9 logs

Post a reply


This question is a means of preventing automated form submissions by spambots.
Smilies
:D :) ;) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :!: :?: :idea: :arrow: :| :mrgreen: :geek: :ugeek:
BBCode is ON
[img] is ON
[url] is ON
Smilies are ON
Topic review
   

If you wish to attach one or more files enter the details below.

Maximum filesize per attachment: 1 MiB.

Expand view Topic review: pre - 2.8.9 logs

Re: pre - 2.8.9 logs

by axew3 » Sat Aug 17, 2024 7:09 am

Fix shortcodes code (views folder):
phpbb_last_topics_withimage_output_shortcode.php
wp_w3all_phpbb_iframe_short.php

Fix: page-forum

Fix important bug about password update.
The version 2.8.9 will be now immediately released due to this.

Updated files:

Code: Select all

/admin/config.php
/admin/wp_w3all_users_to_wp.php
/class.wp.w3all-phpbb.php
/readme.txt
/phpbb_last_topics_withimage_output_shortcode.php
/wp_w3all_phpbb_iframe_short.php
/wp_w3all.php
/addons/iframeresizer/iframe-resizer.child.js
/addons/iframeresizer/iframe-resizer.jquery.js
/addons/iframeresizer/iframe-resizer.parent.js
/addons/page-forum.php
2.8.9 has been released

Re: pre - 2.8.9 logs

by axew3 » Fri Aug 16, 2024 8:45 am

Fix:

Code: Select all

private static function verify_phpbb_credentials(){
adding the missing global var
$w3all_custom_output_files

Code: Select all

private static function verify_phpbb_credentials(){
 global $w3all_custom_output_files,$w3all_link_roles_groups, ... ... ...
so to correctly load the custom wpRoles_phpbbGroups.php if used

viewtopic.php?p=6619#p6619

Re: pre - 2.8.9 logs

by axew3 » Mon Aug 12, 2024 6:37 am

Template integration:

The iframe code has been further more little improved, removing the library repositioning behavior, so activating the related method by default into the template integration page-forum or shortcode code files:

Code: Select all

onScroll: function(x,y){
return false;
}
Also, the overall_footer.html code will little change so to be correctly wrapped and to execute only when required.

Re: pre - 2.8.9 logs

by axew3 » Thu Jul 18, 2024 8:23 am

The iframe resizer lib files will be updated to the latest available release because it fix several issues
https://github.com/davidjbradshaw/ifram ... r/releases
(https://github.com/davidjbradshaw/ifram ... tag/v5.2.0)

There is no problem on using the old iframe-resizer.child.js with the new iframe-resizer.parent.js that will be automatically included when the plugin will update, anyway to have all fixed to the latest and get all benefits, the iframe-resizer.child.js file should be replaced by the new one that can be found into the folder
/wp-content/plugins/wp-w3all-phpbb-integration/addons/iframeresizer/iframe-resizer.child.js

The phpBB template require to be recompiled, if the file iframe-resizer.child.js will be updated with the latest one included on the next 2.8.9 (or the cached one will be used until the template has not been updated).
Anyway, as said, the code will follow working fine even with mismatching parent/child versions.

pre - 2.8.9 logs

by axew3 » Mon Jul 15, 2024 8:47 pm

Template integration issue:

JS error when on reply/post/review and (for example) the preview button is clicked, the console on subsequent loaded page return error:

Code: Select all

Uncaught TypeError: $(...).offset() is undefined
The error above mentioned has been fixed, changing this line into the overall_footer.html js code (that will be now immediately updated/fixed on the help procedure page):

Code: Select all

  if( location.hash.length < 2 ){
change into:

Code: Select all

  if( ! $(window.location.hash).length || location.hash.length < 2 ){
recompile phpBB stale template so to let edits be applied.

It is an !important fix.

Top