2.4.6 pre-release logs and suggestions

Post a reply


This question is a means of preventing automated form submissions by spambots.
Smilies
:D :) ;) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :!: :?: :idea: :arrow: :| :mrgreen: :geek: :ugeek:
BBCode is ON
[img] is ON
[url] is ON
Smilies are ON
Topic review
   

If you wish to attach one or more files enter the details below.

Maximum filesize per attachment: 1 MiB.

Expand view Topic review: 2.4.6 pre-release logs and suggestions

Re: 2.4.6 pre-release logs and suggestions

by axew3 » Tue Jan 04, 2022 7:46 pm

Yes! I hope in few hours to release, tomorrow at max.

More important things added: if the database connection fail, error is reported to all users with manage_options capabilities, both front end and admin pages. If the error is about table prefix only, the button into admin plugin will report error (button red).
No way to fail a setup for anyone!
Note that i have not look too much on how the error display: it only come out when an error occur, so only once if db connection values.
I did not have take care about this. It just display, before <html> tag: i did not enqueued it as it should be, but at moment, it is the unique (and is intentional) "bug" i can find out.

Another thing that has been fixed, is the fact that if for some reason, the connection fail, and users (any, included admins) have to login into wordpress, but they have an hash of phpBB, the plugin will follow to recognize any passed hash (because a modified version of the little function wp_check_password has been moved out of the contest, and it will fire just in case strange situations will come out).

The same function can be used to manage passwords of wordpress users into a very easy plugin of few lines, once the integration may stopped. So that users will have not to reset their passwords, to correctly login in wordpress once integration plugin has been removed.

[EDITED]

w3allOptionsDBerror.png
w3allOptionsDBerror.png (21.54 KiB) Viewed 1883 times

Re: 2.4.6 pre-release logs and suggestions

by GamingSanctum » Tue Jan 04, 2022 3:14 am

Sounds promising! Can't wait to try it out

Re: 2.4.6 pre-release logs and suggestions

by axew3 » Mon Jan 03, 2022 6:47 pm

Since 2.4.6
Php 7 or > better is REQUIRED to install the plugin.
It will not be anymore compatible until old Php 5.6.

Files about widgets and shortcodes have been shortened removing switch for iframe or not iframe integration (because the overall_header.html js code applied into phpBB, do not justify anymore this in wp side).
By the way the complete cleanup of these things will happen on next versions. And old custom files will works as ever (even if anybody should switch to the new cleaned and faster code).
All widgets and shortcodes returns to fully work by default (almost into actual wp 5.9 devel version) into admin

Re: 2.4.6 pre-release logs and suggestions

by axew3 » Mon Jan 03, 2022 1:01 pm

The verify_credentials function has been fixed about a discrepancy that was coming out in certain circumstances.
It has been fixed.
The entire function (except something i would like to change, about redirects when login happen in certain cases) seem to me perfect and fast as nothing could be more.

The config admin page is more comfortable (i think), and several fixes applied all around.

Updating to 2.4.6 mean also to leave the phpBB config.php inclusion.
All will be easier for anyone.
Old install will have to do nothing. The new option is auto-populated when plugin update to 2.4.6, visiting the plugin admin page.
The code has been shortened under this aspect and on next versions all the rest will be cleaned.

All widgets and shortcodes working on wp 5.9

Going to test all results, so 2.4.6 will be released

Stay tuned lovely people, it will be cool!

ps... so it should be faster
This make no difference about how the code is fast.
A file inclusion, even if very fast, require to be performed.
To establish what of the way is the faster (that should be milliseconds) i would be curios.
get_option() (autoloaded), so a query to get the option, or include the file?
Since the path was anyway stored into a wp option, i assume that now we gain some millisecond.
The inclusion was happening by the way, after get_option executed. And now get_option retrieve more options that have been unified, not only db connection values. Should be faster-

Re: 2.4.6 pre-release logs and suggestions

by axew3 » Sat Jan 01, 2022 3:01 pm

It is intended that if using the iframe mode (which code will move to V6 soon), then the overall_header js code is applied.
Since it rewrite and reload any direct url via js, there is no need to apply the js url switch into widgets and shortcodes output when onmouseover.
So the little js code about this will be removed into default files, while the function and hook about this leaved in place due to possible custom installations using custom old files.

Re: 2.4.6 pre-release logs and suggestions

by axew3 » Sat Jan 01, 2022 2:32 pm

The phpBB config.php inclusion will be abandoned into next coming soon 2.4.6.
The configuration to the phpBB db connection, will be automatic into old active installations.
No action required.

New way to setup values for the phpBB database connection will be now directly into plugin admin.

This make no difference about how the code is fast.
A file inclusion, even if very fast, require to be performed.
To establish what of the way is the faster (that should be milliseconds) i would be curios.
get_option() (autoloaded), so a query to get the option, or include the file?
Since the path was anyway stored into a wp option, i assume that now we gain some millisecond.
The inclusion was happening by the way, after get_option executed. And now get_option retrieve more options that have been unified, not only db connection values. Should be faster-

All the code has been shortened again. And more fixes applied all around-
[EDITED]
2021-12-29w3allOptionsWordPress2.png
2021-12-29w3allOptionsWordPress2.png (31.81 KiB) Viewed 1939 times

Top