phpbb moved/shadow topics, display twice thru widget

Post a reply


This question is a means of preventing automated form submissions by spambots.
Smilies
:D :) ;) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :!: :?: :idea: :arrow: :| :mrgreen: :geek: :ugeek:

BBCode is ON
[img] is ON
[url] is ON
Smilies are ON

Topic review
   

If you wish to attach one or more files enter the details below.

Maximum filesize per attachment: 1 MiB.

Expand view Topic review: phpbb moved/shadow topics, display twice thru widget

Re: phpbb moved/shadow topics, display twice thru widget

by kaspir » Fri Sep 22, 2017 5:22 am

Awesome! had a feeling I was the first to catch that.. dunno why I was even playing with shadow topics.. lol.

Re: phpbb moved/shadow topics, display twice thru widget

by axew3 » Thu Sep 14, 2017 10:08 am

It has been fixed on 1.7.5.
Was necessary to change the query for last posts adding DISTINCT and GROUP BY clause.

so the first query (and subsequent queries on same function in the same way) on class WP_w3all ->function last_forums_topics() have been changed into this on coming 1.7.5:

Code: Select all

              $topics = $w3db_conn->get_results("SELECT DISTINCT T.*, P.*, U.* FROM ".$config["table_prefix"]."topics AS T, ".$config["table_prefix"]."posts AS P, ".$config["table_prefix"]."users AS U 
              WHERE T.topic_visibility = 1 
              AND T.topic_last_post_id = P.post_id 
              AND P.post_visibility = 1 
              ".$topics_x_ugroup." 
              AND U.user_id = T.topic_last_poster_id 
              GROUP BY P.topic_id
              ORDER BY T.topic_last_post_time DESC LIMIT 0,$ntopics");
going to write the necessary "messy tutorials" about new features and fixes and additions, so releasing 1.7.5

Re: phpbb moved/shadow topics, display twice thru widget

by kaspir » Tue Sep 12, 2017 4:50 am

LOL, that sounds great friend. You know me, just dropping a line to inform if you werent aware. Im never demanding about it.

I wasnt aware of many bugs, but i never have any doubt, your on top of it! Take ur time.. your plugin is your beautiful baby!

Thx as always!

Re: phpbb moved/shadow topics, display twice thru widget

by axew3 » Mon Sep 11, 2017 3:35 pm

mumble mumble .... hey Greg, i've discover numerous of bug problems on 1.7.4, that have been fixed on 1.7.5!
About profiles, last topics and a subsequence of behaviors due to some code fail in certain conditions. Really many.
I've take a time to rebuild many things at best possible, due to main code structure.
I'm over today, after long suffering time here! Now i'm on routine another time, summer is finished.

Shadow posts not included on last topics widgets will be resolved as soon, probably also into this 1.7.5.
Let take note!

phpbb moved/shadow topics, display twice thru widget

by kaspir » Mon Sep 11, 2017 3:23 pm

I had moved a topic (moderator privledge) and had left a 'shadow' topic in the original forum. I now have a dupe on the last topics widget.

:idea:
Whenever free time is available (so hard to find right?!), I request adjust script to stop shadow topics from displaying. This would correct any moved phpbb topics (with a shadow left behind) from displaying twice in w3all.. what a great plugin!

Thank you!

Top